Update pyyaml version breaking installation #328
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent update to cython3 has broken some of the older version of pyyaml, this makes it so that the versions that can be installed are the ones that are not broken
Reference Issues/PRs
This is related to an issue with the pyyaml library which is one of the dependencies: yaml/pyyaml#724
What does this implement/fix? Explain your changes
Currently, if you try downloading
graphein
you get the following error (this was tested with python v3.10.* and 3.12.*):This PR fixes this by fixing updating the
pyyaml
version to:pyyaml!=6.0.0,!=5.4.0,!=5.4.1
What testing did you do to verify the changes in this PR?
I am unable to verify whether my changes made the following tests, as I am unable to install the older version due to the error above. The following tests are currently failing:
Pull Request Checklist
./CHANGELOG.md
file (if applicable)./graphein/tests/*
directories (if applicable)./notebooks/
(if applicable)python -m py.test tests/
and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g.,python -m py.test tests/protein/test_graphs.py
)black .
andisort .