-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
addGroupingActivity() calls always initiate an empty array #160
Comments
brian-learningpool
added a commit
to brian-learningpool/xAPIWrapper
that referenced
this issue
Jan 15, 2020
This was overwriting any existing array items in calls such as addGroupingActivity().
Not sure, I'll take a look at this in a bit. |
Yeah, this does look like a mistake. Just going into a console, you can see the behavior isn't correct:
Go ahead and submit that change for a PR and I'll move it through. |
FlorianTolk
added a commit
that referenced
this issue
Jan 16, 2020
Resolves #160, corrects issue with _getobj()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I noticed that the first statement was lost while trying to add two grouped items to my xAPI statement via
addGroupingActivity()
method. Is this by design or a bug?I think maybe
_getobj()
requires a check before returning an empty array onxAPIWrapper/src/xapistatement.js
Line 12 in c7bc09f
Something like
The text was updated successfully, but these errors were encountered: