Improve Cutout augmentation #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow cutting out random number of regions. * Allow cutting out regions of random size. * Slightly simplify the code and remove the code which always creates patches of even height and width. * Add sanity checks for non-negative parameters. * Fix documentation which mentions squares being zeroed out from the image while the applied patches can be rectangular. * Change tests so that serialization is provided with new parameters.
ternaus
reviewed
May 20, 2019
|
we have to preserve old api to not break pipelines with updates, let's make two versions and deprecation warning for previous (for 0.4.0) |
As mentioned by @albu, it would be better to preserve API by deprecating current `Cutout` class and introducing another version of it.
|
@albu I'm not sure what's the best way to do that, but I've tried to address your comment in my last commit by introducing |
|
Yes, thanks. I think it's perfect option. Just make few style fixes as reported by travis and we can merge it |
Import multiple items using parenthesis as suggested in PEP 328 https://www.python.org/dev/peps/pep-0328/#rationale-for-parentheses
|
@albu Great, thanks! I've fixed CI issues and the patch should be ready for the merge now. |
albu
approved these changes
May 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
patches of even height and width.
image while the applied patches can be rectangular.
Implements the first part of #263.