-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github action: add deploy workflow #163
Conversation
@junghans, this is awesome, thanks for the contribution! Overall, LGTM. Before merging this PR, let me play with the config to make sure it takes care of all / most of use cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Could you please explain and document the logic of this workflow a bit more by answering a couple of questions I left inline? I'd be happy to merge after that. Thanks.
Co-authored-by: Maruan <[email protected]>
* Github action: add deploy workflow * Update .github/workflows/deploy.yml Co-authored-by: Maruan <[email protected]> [ci skip]
* Github action: add deploy workflow * Update .github/workflows/deploy.yml Co-authored-by: Maruan <[email protected]>
* Github action: add deploy workflow * Update .github/workflows/deploy.yml Co-authored-by: Maruan <[email protected]>
* Github action: add deploy workflow * Update .github/workflows/deploy.yml Co-authored-by: Maruan <[email protected]>
This fixes issues mentioned in alshedivat#163
* Github action: add deploy workflow * Update .github/workflows/deploy.yml Co-authored-by: Maruan <[email protected]>
* Github action: add deploy workflow * Update .github/workflows/deploy.yml Co-authored-by: Maruan <[email protected]>
This will automatically deploy the page when pushing to source branch (i.e.
master
andsource
).That basically allows editing through the GitHub web interface, no more need to install bundler locally.
This also supports pull requests, which can be useful to collaboratively make a conference page. For PRs the whole build is still done except the actual
git push
at the end. To achieve this I added a--dry-run
option tobin/deploy
.Side notes:
--verbose
option to make debugging ofbin/deploy
easierexit 0
)--user
option callingshift
twicemaster
/source
(and PR to these, but PR are not deployed)..github.io
repo, the deploy branch is switched fromgh-pages
tomaster
.bin/deploy
are backward compatible