Fix titles and headings

[akindofyoga]

The If statements to decide the page title and header seemed incorrect. This fixes these.

[alshedivat]

Thanks for the contribution. Which exact issue does this PR fix?

[akindofyoga]

{{ site.title }} was never getting used as the title and heading. The condition if site.title == blank was never true, because blank was not in quotes. In addition, {{ site.title }} is the wrong value to use in this case.

To see the problem, try using the theme with title set as blank.

[alshedivat]

@rogerthat94, thanks for pointing this out. Looks like the bug was introduced in this commit. If that's the case, then _layouts/about.html probably has the same issue. Could you please confirm that?

On a stylistic note, how about we switch from {% if site.title == "blank" %} to just {% if site.title %} and flip the true and false branches? I just find it weird that liquid evaluates "" == "blank" to true.

And thanks again for spotting this!

[akindofyoga]

We don't want to look for site.title being undefined. We want to check if it's specifically the string "blank"

See

al-folio/_config.yml

Line 5 in 9229f7d

title: blank # the website title (if blank, full name will be used instead)

If you'd rather check {% if site.title %}, we should change _config.yml to comment out the title and say "the website title (if undefined, full name will be used instead)"