Enhance mmap value store with dynamic pre-allocation, robust indexing, naming changes #260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Enhance mmap value store with the following changes:
_BytesBatchGetterValPreAlloc
return a 2D list with individual sliced memoryview so that users don't need to have afterward slicing.n_sub_row
andn_sub_col
touint64
to avoid potential large numbers of entriessubmatrix
tobatch_get
to be consistent with key mappersnum_f32
tofloat32
to be consistent across the codestr_mmap
tobytes_mmap
to be accurate in terms of user-given inputsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.