Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance mmap value store with dynamic pre-allocation, robust indexing, naming changes #260

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

hallogameboy
Copy link
Contributor

@hallogameboy hallogameboy commented Oct 4, 2023

Issue #, if available:
N/A

Description of changes:

Enhance mmap value store with the following changes:

  • Functionalities
    • Enable dynamic pre-allocation for both of greater row and column numbers
    • Let _BytesBatchGetterValPreAlloc return a 2D list with individual sliced memoryview so that users don't need to have afterward slicing.
  • Data types
    • Switch n_sub_row and n_sub_col to uint64 to avoid potential large numbers of entries
  • Naming
    • Change submatrix to batch_get to be consistent with key mappers
    • Change num_f32 to float32 to be consistent across the code
    • Change str_mmap to bytes_mmap to be accurate in terms of user-given inputs

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hallogameboy hallogameboy merged commit d864e60 into amzn:mainline Oct 5, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants