Enhance String ValStore Python speed #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pecos/utils/mmap_valstore_util.py
Outdated
| # Pre-calculated memory view of each string | ||
| # For str decoding, from memory view is faster than from Numpy view | ||
| bytes_start_loc = ( | ||
| np.arange(max_row_size * max_col_size, dtype=np.int64) * self.trunc_val_len |
There was a problem hiding this comment.
Shall the dtype be np.uint64?
There was a problem hiding this comment.
Thanks for pointing out, modified.
d2f1a51
to
9ff5a2d
Compare
9ff5a2d
to
c2b4fb4
Compare
hallogameboy
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Accelerate String ValueStore batch get.
For 66M rows, 10 cols string store, batch get of sub-matrix time cost is reduced by 60%:
Also for Float32 ValueStore, return Numpy view instead of Python MemoryView to connect with Torch tensor.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.