Implement Memory-mapped MLModel #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37437c5
to
5c06b9e
Compare
weiliw-amz
reviewed
Jan 9, 2024
| @@ -1168,3 +1168,36 @@ def test_mmap(tmpdir): | |||
| py_pred = py_model.predict(Xt, **kwargs).todense() | |||
| mmap_pred = mmap_model.predict(Xt, **kwargs).todense() | |||
| assert mmap_pred == approx(py_pred, abs=1e-6), f"post_processor:{pp}" | |||
|
|
|||
|
|
|||
| def test_mmap_mlmodel(tmpdir): | |||
There was a problem hiding this comment.
I think this test should be put in https://github.com/amzn/pecos/blob/mainline/test/pecos/xmc/test_xmc.py since the functionalities added are for the xmc/base.py class.
There was a problem hiding this comment.
Fixed. See latest Revision.
weiliw-amz
reviewed
Jan 9, 2024
pecos/core/libpecos.cpp
Outdated
| // ==== C Interface of XMC Models ==== | ||
| // ==== C Interface of MLModels ==== | ||
| // Only implemented for w_matrix_t = pecos::csc_t | ||
| //typedef pecos::bin_search_chunked_matrix_t MLMODEL_MAT_T; |
There was a problem hiding this comment.
Remove this unused comment.
There was a problem hiding this comment.
Fixed. See latest Revision.
5c06b9e
to
8f397c0
Compare
weiliw-amz
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Implement Memory-mapped MLModel class for both C and Python Interface.
Usage
User needs to have a MLModel saved on disk (in original .npz format),
and manually compile into mmap format by calling compile_mmap_model:
Then user can load the memory-mapped model and do inference:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.