#223 Port rds_subnet_group to boto3 #224
Conversation
There was a problem hiding this comment.
Thank you for taking the time to port this code over to boto3, it's very much appreciated. Something went wrong with the integration tests so they didn't run properly the second time, but I suspect they're going to throw up some of the issues in my review.
Additionally, please would you add a changelog entry: https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to
|
Thanks the prompt review.
Fairly sure I would had missed some parts. For example, I noticed afterward the existing module does'nt have an
Will do. |
|
Right, end of day for me here, but I'll try to get this done in the coming days. Thanks. |
|
It looks like the tests will need some minor tweaks (the error messages have changed) you can find them in tests/integration/targets/rds_subnet_group |
|
ANSIBLE_METADATA is no longer needed, it went away as a part of the big split: ansible-collections/overview#57 |
|
Right, tests are still failing (and I messed up the document "sample" part). I'll need to setup properly and re-run all that. Leaving as draft until I've resolved it. |
|
@tremble Right, build failed as something timed out, I don't think I can re-trigger it myself. |
|
@pm98zz-c this PR contains the following merge commits: Please rebase your branch to remove these commits. |
Co-authored-by: Mark Chappell <[email protected]>
Co-authored-by: Mark Chappell <[email protected]>
|
Thank-you for your contribution. That's one less boto v2 based module. |
|
Cheers, thanks for your patience. First time around, it'll be more straightforward next time! |
…ctions#224) * Port rds_subnet_group to boto3 * Linting fixes * Add more meaningful error messages, add changelog fragment * Remove test on mandatory args for state absent
…ctions#224) * Port rds_subnet_group to boto3 * Linting fixes * Add more meaningful error messages, add changelog fragment * Remove test on mandatory args for state absent
…s#224) Initial integration tests for ec2_vpc_dhcp_option. Based on work started in ansible-collections#109 Co-authored-by: s-hertel <[email protected]>
…ctions#224) * Port rds_subnet_group to boto3 * Linting fixes * Add more meaningful error messages, add changelog fragment * Remove test on mandatory args for state absent This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@c19d479
SUMMARY
Use boto3 instead of boto (and remove logic on mandatory arguments on state: absent)
ISSUE TYPE
COMPONENT NAME
rds_subnet_group.py
ADDITIONAL INFORMATION
I've only focused on the minimal work to get it working in the same way as it was from a functional point of view. Would probably need some tests and a few additional features (like support for tags), but seems to be working for my use case.