-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize the message of DatabaseServerInfo
#28428
Conversation
Hi @134130 In ShardingSphere, we use Please refer to: |
@RaigorJiang Yeah, I've considered using But I am open to changing message to Database type ;) |
In ShardingSphere's Design Philosophy, |
Since ShardingSphere uses
Are you saying database only means Relational databases? I think "Heterogeneous databases" contains all of |
It seems so. |
@134130 Merged, thank you! |
Fixes #28421.
in: proxy
type: refactor
Changes proposed in this pull request:
MySQL
as "DBMS product name" or "DBMS name". Just "DBMS" isMySQL
.DBMS
is clear.DatabaseServer
's name means DatabaseProduct's nameBefore committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e
.I have made corresponding changes to the documentation.