Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dubbo example with annotation #1467

Merged
merged 3 commits into from
May 15, 2021
Merged

Add dubbo example with annotation #1467

merged 3 commits into from
May 15, 2021

Conversation

KevinClair
Copy link
Member

// Describe your PR here; eg. Fixes #issueNo
Associate with issues #1466

  • Add alibaba dubbo example with annotation.
  • Add apache dubbo example with annotation.

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed mvn clean install -Dmaven.javadoc.skip=true.
Siteproxy
@codecov-commenter
Copy link

codecov-commenter commented May 15, 2021

Codecov Report

Merging #1467 (0a560ad) into master (b5891ac) will increase coverage by 0.57%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1467      +/-   ##
============================================
+ Coverage     63.40%   63.98%   +0.57%     
- Complexity     2035     2043       +8     
============================================
  Files           407      407              
  Lines          8797     8797              
  Branches        880      880              
============================================
+ Hits           5578     5629      +51     
+ Misses         2800     2748      -52     
- Partials        419      420       +1     
Impacted Files Coverage Δ Complexity Δ
...che/shenyu/sync/data/http/HttpSyncDataService.java 70.58% <0.00%> (+6.86%) 12.00% <0.00%> (ø%)
...enyu/client/tars/TarsServiceBeanPostProcessor.java 82.92% <0.00%> (+53.65%) 14.00% <0.00%> (+8.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5891ac...0a560ad. Read the comment docs.

@kimmking kimmking merged commit c777e5b into apache:master May 15, 2021
@KevinClair KevinClair deleted the #1466 branch May 16, 2021 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants