Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[type:fix] Add SPI @Join annotation to the isSingleton() property #3955

Merged
merged 2 commits into from
Sep 17, 2022

Conversation

prFor
Copy link
Contributor

@prFor prFor commented Sep 16, 2022

Make sure that:

  • [V] You have read the contribution guidelines.
  • [V] You submit test cases (unit or integration tests) that back your changes.
  • [V] Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2022

Codecov Report

Merging #3955 (4792d71) into master (14ec556) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #3955      +/-   ##
============================================
- Coverage     70.16%   70.14%   -0.03%     
+ Complexity     6678     6677       -1     
============================================
  Files           923      923              
  Lines         25071    25067       -4     
  Branches       2264     2264              
============================================
- Hits          17590    17582       -8     
- Misses         6112     6120       +8     
+ Partials       1369     1365       -4     
Impacted Files Coverage Δ
...in/java/org/apache/shenyu/spi/ExtensionLoader.java 86.58% <100.00%> (-0.92%) ⬇️
...controller/ShenyuClientHttpRegistryController.java 77.77% <0.00%> (-22.23%) ⬇️
...ruptor/RegisterClientServerDisruptorPublisher.java 52.94% <0.00%> (-11.77%) ⬇️
...shenyu/sync/data/consul/ConsulSyncDataService.java 80.00% <0.00%> (+1.66%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yu199195 yu199195 added this to the 2.5.1 milestone Sep 17, 2022
@yu199195 yu199195 merged commit 20576a2 into apache:master Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants