Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[type:refactor] Refactor sdk factory. #4119

Merged
merged 17 commits into from
Oct 21, 2022

Conversation

yunlongn
Copy link
Member

[type:refactor] Refactor sdk factory.

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.
Siteproxy
@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2022

Codecov Report

Merging #4119 (3308c03) into master (0453b48) will decrease coverage by 0.10%.
The diff coverage is 39.02%.

@@             Coverage Diff              @@
##             master    #4119      +/-   ##
============================================
- Coverage     70.23%   70.12%   -0.11%     
- Complexity     6892     6894       +2     
============================================
  Files           944      944              
  Lines         25913    25950      +37     
  Branches       2329     2330       +1     
============================================
- Hits          18199    18197       -2     
- Misses         6296     6338      +42     
+ Partials       1418     1415       -3     
Impacted Files Coverage Δ
.../java/org/apache/shenyu/common/utils/UriUtils.java 50.00% <0.00%> (-20.00%) ⬇️
...che/shenyu/sdk/httpclient/HttpShenyuSdkClient.java 31.14% <16.00%> (-10.96%) ⬇️
...pache/shenyu/sdk/okhttp/OkHttpShenyuSdkClient.java 27.08% <100.00%> (-30.82%) ⬇️
...che/shenyu/sync/data/http/HttpSyncDataService.java 89.79% <0.00%> (+4.08%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

moremind and others added 2 commits October 21, 2022 10:10

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@yu199195 yu199195 added the sdk label Oct 21, 2022
@yu199195 yu199195 added this to the 2.5.1 milestone Oct 21, 2022
@yu199195 yu199195 merged commit 6449151 into apache:master Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants