[Task #3011]The JwtRuleHandle should be coustomerd

[tian-pengfei]

Make sure that:

• You have read the contribution guidelines.
• You submit test cases (unit or integration tests) that back your changes.
• Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

finished task #3011

client could be customed JwtRuleHandle
for example

/**
 * isSingleton is false  , because JwtRuleHandle is stateful.
 */
@Join(isSingleton = false)
public class CustomJwtRuleHandle implements JwtRuleHandle {
    private String handleJson;

    @Override
    public void init(final String handleJson) {
        this.handleJson = handleJson;
    }

    @Override
    public ServerWebExchange execute(final ServerWebExchange exchange, final Map<String, Object> jwtBody) {
        // handle exchange by config(handleJson),return new exchange
        return exchange;
    }

    @Override
    public String toJson() {
        return handleJson;
    }
}

custom=org.apache.shenyu.plugin.jwt.rule.CustomJwtRuleHandle

handle format is

{"handleType":custom","customConfig":"customConfig"}

[codecov-commenter]

Codecov Report

Merging #4133 (aebce40) into master (5ed30ca) will decrease coverage by 0.07%.
The diff coverage is 70.68%.

@@             Coverage Diff              @@
##             master    #4133      +/-   ##
============================================
- Coverage     70.33%   70.25%   -0.08%     
- Complexity     7172     7174       +2     
============================================
  Files           965      968       +3     
  Lines         26934    26962      +28     
  Branches       2399     2403       +4     
============================================
- Hits          18944    18943       -1     
- Misses         6538     6563      +25     
- Partials       1452     1456       +4     

Impacted Files	Coverage Δ
...n/java/org/apache/shenyu/plugin/jwt/JwtPlugin.java	51.21% <45.45%> (-11.75%)	⬇️
...plugin/jwt/strategy/DefaultJwtConvertStrategy.java	73.07% <73.07%> (ø)
...g/apache/shenyu/plugin/jwt/rule/JwtRuleHandle.java	75.00% <75.00%> (ø)
...plugin/jwt/strategy/JwtConvertStrategyFactory.java	80.00% <80.00%> (ø)
...shenyu/plugin/jwt/handle/JwtPluginDataHandler.java	100.00% <100.00%> (ø)
...e/shenyu/plugin/jwt/rule/DefaultJwtRuleHandle.java	41.66% <100.00%> (ø)
...controller/ShenyuClientHttpRegistryController.java	77.77% <0.00%> (-22.23%)	⬇️
...ruptor/RegisterClientServerDisruptorPublisher.java	52.94% <0.00%> (-11.77%)	⬇️
.../plugin/grpc/loadbalance/AbstractLoadBalancer.java	70.65% <0.00%> (-8.70%)	⬇️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[moremind]

why do you do like this?

[tian-pengfei]

@moremind @li-keguo Hi guys,I have refactored it again , please check and give me some advice

[li-keguo]

You can skip generics here,

JwtRuleHandle parseHandleJson(String handleJson);

This also returns a subclass without warning

no SuppressWarnings

[tian-pengfei]

Thank you for the advice,but I think it has a problem . If you replace generics by JwtRuleHandle, it can happen class type of the result of executing parseHandleJson is diffrent from first parameter of ServerWebExchange convert. I think it is unreasonable for this to happen

[li-keguo]

parseHandleJson must return : JwtRuleHandle or ? extent JwtRuleHandle

Generics are weakly constrained and type-ambiguous.
It's better to have a strong constraint here

eg:

@SuppressWarnings
public class MyJwtConvertStrategy implements JwtConvertStrategy {

   Object parseHandleJson(String handleJson){
    // ... ... 
    }
}

[li-keguo]

Looks like a lot of good

[tian-pengfei]

Looks like a lot of good

Thanks <3

[moremind]

you maybe know spi

[li-keguo]

parseHandleJson must return : JwtRuleHandle or ? extent JwtRuleHandle

Generics are weakly constrained and type-ambiguous.
It's better to have a strong constraint here

eg:

@SuppressWarnings
public class MyJwtConvertStrategy implements JwtConvertStrategy {

   Object parseHandleJson(String handleJson){
    // ... ... 
    }
}