Get Sentry DSN from environment variable #64
Merged
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartwork
reviewed
Aug 16, 2020
| @@ -253,6 +253,10 @@ Report errors to Sentry by passing a Sentry DSN: | |||
| $ ./supercronic -sentry-dsn DSN | |||
| ``` | |||
|
|
|||
| You can also specify the DSN via the `SENTRY_DSN` environment variable. | |||
| When a DSN is specified via both the environment variable and the command line parameter | |||
There was a problem hiding this comment.
I think adding a comma at the end of this line would help cognitive flow. Just an idea.
krallin
approved these changes
Nov 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the Sentry SDK in Go, it usually also reads the DSN from the SENTRY_DSN environment variable
This way Sentry can be configured from outside the container and one does not need an entrypoint to get the DSN from said environment variable.