Explain LINKER_ERROR

[0xbe1]

fix #5663

Description

Test Plan

[clay-aptos]

Thank you again!

[banool]

This is a good start but I'd like more detail. This doesn't really tell users what is specifically wrong and how to debug it. Perhaps someone from the Move team could help? cc @movekevin

[banool]

One example of a LINKER_ERROR: If you try to call a function that does not exist on chain. For example, if you call a module that you have the source for locally, but have not published that module on chain, it’ll fail when you try to actually run it.

[clay-aptos]

I'm noting we should also port these updates back to the source files.

[gregnazario]

LINKER_ERROR actually has a bunch of possible reasons, but I think this helps either way for now cc @wrwg if he knows anyone who can give a more complete answer.

Thanks for adding this!

[banool]

Sorry but "The function that your command is executing is not a valid function. Double-check your command" is not very useful, it is far too vague. What does valid mean? What do we mean by command? I don't see the value in landing this as is.

[0xbe1]

@banool agreed! I have improved the case that I know of combining your input. Can you take another look? Thanks

[davidiw]

thanks, adjusted

manually addressed

[github-actions]

✅ Forge suite land_blocking success on e004af979afeb8023c084b3c727afc435fdf4b63

performance benchmark with full nodes : 6919 TPS, 5739 ms latency, 9300 ms p99 latency,no expired txns
Test Ok

• Grafana dashboard
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> e004af979afeb8023c084b3c727afc435fdf4b63

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> e004af979afeb8023c084b3c727afc435fdf4b63 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7091 TPS, 5464 ms latency, 7500 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: e004af979afeb8023c084b3c727afc435fdf4b63
compatibility::simple-validator-upgrade::single-validator-upgrade : 5128 TPS, 7830 ms latency, 9600 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: e004af979afeb8023c084b3c727afc435fdf4b63
compatibility::simple-validator-upgrade::half-validator-upgrade : 4474 TPS, 8882 ms latency, 12400 ms p99 latency,no expired txns
4. upgrading second batch to new version: e004af979afeb8023c084b3c727afc435fdf4b63
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6766 TPS, 5791 ms latency, 9400 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> e004af979afeb8023c084b3c727afc435fdf4b63 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Test runner output
• Test run is land-blocking