Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update move scripts docs to match banool's move-examples repo #8008

Merged
merged 3 commits into from
May 13, 2023

Conversation

0xbe1
Copy link
Contributor

@0xbe1 0xbe1 commented May 2, 2023

Description

🤖 Generated by Copilot at 95e1507

This pull request improves the Move scripts tutorial in move-scripts.md by making it easier to follow, more realistic, and more consistent with the latest Aptos features.

Test Plan

AI-powered Walkthrough

🤖 Generated by Copilot at 95e1507

  • Add a line of code to the example script that calls a function from a user-defined module (link)
  • Simplify the steps for setting up the Aptos CLI, initializing a Move project, and creating the source files by using the --network flag, a different account and private key, and renaming the project and script to run_script (link)
  • Update the file structure and the compilation command to use the new project and script names (link)
  • Update the output of the aptos move run-script command to show the actual result of running the script with the new account and network (link)
  • Update the note about the path of the compiled script to use the new project name (link)

@0xbe1 0xbe1 requested a review from saharct as a code owner May 2, 2023 12:43
Copy link
Contributor

@saharct saharct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding @banool for review.

@saharct saharct requested a review from banool May 5, 2023 11:45
Copy link
Contributor

@banool banool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

mkdir testing
cd testing
```
```sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think indentation does anything here since it’s markdown

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@movekevin with and without indentation:
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting TIL 🚀🚀

@movekevin movekevin enabled auto-merge (squash) May 9, 2023 17:00
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

❌ Forge suite land_blocking failure on bc97c962981e01c7aef67d6c148ca67cf2fe03f6

Forge test runner terminated:
Trailing Log Lines:
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/panicking.rs:483:40
      std::panicking::try
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/panicking.rs:447:19
      std::panic::catch_unwind
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/panic.rs:137:14
      std::rt::lang_start_internal
             at /rustc/90743e7298aca107ddaa0c202a4d3604e29bfeb6/library/std/src/rt.rs:148:20
  12: main
  13: __libc_start_main
  14: _start
Debugging output:

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> bc97c962981e01c7aef67d6c148ca67cf2fe03f6

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> bc97c962981e01c7aef67d6c148ca67cf2fe03f6 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7708 TPS, 5018 ms latency, 7400 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: bc97c962981e01c7aef67d6c148ca67cf2fe03f6
compatibility::simple-validator-upgrade::single-validator-upgrade : 4536 TPS, 8963 ms latency, 11300 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: bc97c962981e01c7aef67d6c148ca67cf2fe03f6
compatibility::simple-validator-upgrade::half-validator-upgrade : 4662 TPS, 8424 ms latency, 12300 ms p99 latency,no expired txns
4. upgrading second batch to new version: bc97c962981e01c7aef67d6c148ca67cf2fe03f6
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6198 TPS, 6127 ms latency, 10100 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> bc97c962981e01c7aef67d6c148ca67cf2fe03f6 passed
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

✅ Forge suite framework_upgrade success on aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> bc97c962981e01c7aef67d6c148ca67cf2fe03f6

Compatibility test results for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> bc97c962981e01c7aef67d6c148ca67cf2fe03f6 (PR)
Upgrade the nodes to version: bc97c962981e01c7aef67d6c148ca67cf2fe03f6
framework_upgrade::framework-upgrade::full-framework-upgrade : 5901 TPS, 6645 ms latency, 9600 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> bc97c962981e01c7aef67d6c148ca67cf2fe03f6 passed
Test Ok

@davidiw davidiw disabled auto-merge May 13, 2023 17:54
@davidiw davidiw enabled auto-merge (squash) May 13, 2023 17:55
@davidiw davidiw disabled auto-merge May 13, 2023 17:55
@davidiw davidiw merged commit dec5495 into aptos-labs:main May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants