Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix principal calculation explanation #8033

Merged
merged 1 commit into from
May 6, 2023
Merged

Conversation

0xbe1
Copy link
Contributor

@0xbe1 0xbe1 commented May 3, 2023

active principal = add - unlock + reactivate. it can go negative only b/c unlock include rewards. reactivate doesn't contribute to the negativity.

likewise to pending inactive principal.

Description

🤖 Generated by Copilot at ad59998

Fix a typo in the documentation of the delegation pool rewards calculation algorithm. The change corrects the conditions for negative principal in delegation-pool-operations.md.

Test Plan

active principal = add - unlock + reactivate. it can go negative only b/c unlock include rewards. reactivate doesn't contribute to the negativity.

likewise to pending inactive principal.
@0xbe1 0xbe1 requested a review from saharct as a code owner May 3, 2023 08:50
@movekevin movekevin requested a review from jillxuu May 4, 2023 17:48
Copy link
Contributor

@saharct saharct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @0xbe1!

@davidiw davidiw merged commit a14bced into aptos-labs:main May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants