Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in stake.move comments #8949

Merged
merged 2 commits into from
Jul 16, 2023
Merged

fix typo in stake.move comments #8949

merged 2 commits into from
Jul 16, 2023

Conversation

0xbe1
Copy link
Contributor

@0xbe1 0xbe1 commented Jul 5, 2023

Description

Test Plan

@0xbe1 0xbe1 requested review from davidiw, movekevin and wrwg as code owners July 5, 2023 01:31
@davidiw davidiw enabled auto-merge (squash) July 15, 2023 20:45
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.5.1 ==> efcce6e40d1a98890ec33ca7cb501fc83763d189

Compatibility test results for aptos-node-v1.5.1 ==> efcce6e40d1a98890ec33ca7cb501fc83763d189 (PR)
1. Check liveness of validators at old version: aptos-node-v1.5.1
compatibility::simple-validator-upgrade::liveness-check : committed: 4894 txn/s, latency: 6606 ms, (p50: 6400 ms, p90: 9800 ms, p99: 11100 ms), latency samples: 195780
2. Upgrading first Validator to new version: efcce6e40d1a98890ec33ca7cb501fc83763d189
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1781 txn/s, latency: 16191 ms, (p50: 19100 ms, p90: 22200 ms, p99: 22500 ms), latency samples: 92660
3. Upgrading rest of first batch to new version: efcce6e40d1a98890ec33ca7cb501fc83763d189
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1881 txn/s, latency: 15555 ms, (p50: 18400 ms, p90: 21900 ms, p99: 22200 ms), latency samples: 92180
4. upgrading second batch to new version: efcce6e40d1a98890ec33ca7cb501fc83763d189
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3237 txn/s, latency: 9410 ms, (p50: 10000 ms, p90: 12900 ms, p99: 13600 ms), latency samples: 139200
5. check swarm health
Compatibility test for aptos-node-v1.5.1 ==> efcce6e40d1a98890ec33ca7cb501fc83763d189 passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on efcce6e40d1a98890ec33ca7cb501fc83763d189

two traffics test: inner traffic : committed: 5398 txn/s, latency: 7248 ms, (p50: 6900 ms, p90: 9200 ms, p99: 12900 ms), latency samples: 2342860
two traffics test : committed: 100 txn/s, latency: 2661 ms, (p50: 2600 ms, p90: 3000 ms, p99: 4400 ms), latency samples: 1840
Max round gap was 1 [limit 4] at version 1185510. Max no progress secs was 3.925678 [limit 10] at version 1185510.
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.5.1 ==> efcce6e40d1a98890ec33ca7cb501fc83763d189

Compatibility test results for aptos-node-v1.5.1 ==> efcce6e40d1a98890ec33ca7cb501fc83763d189 (PR)
Upgrade the nodes to version: efcce6e40d1a98890ec33ca7cb501fc83763d189
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4810 txn/s, latency: 6837 ms, (p50: 6500 ms, p90: 10500 ms, p99: 12000 ms), latency samples: 177980
5. check swarm health
Compatibility test for aptos-node-v1.5.1 ==> efcce6e40d1a98890ec33ca7cb501fc83763d189 passed
Test Ok

@davidiw davidiw merged commit c82fdb7 into aptos-labs:main Jul 16, 2023
banool pushed a commit that referenced this pull request Jul 19, 2023
gedigi pushed a commit that referenced this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants