[ENHANCEMENT] Get record by ID - refresh record resource #5500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frascuchon
commented
Sep 17, 2024
| selectinload(Record.suggestions), | ||
| selectinload(Record.responses), |
There was a problem hiding this comment.
In a future step, this can be controlled by with_* query parameters as we already have for other record endpoints.
frascuchon
commented
Sep 17, 2024
| """Retrieves the record from the server.""" | ||
| model = self._client.api.records.get(self._server_id) | ||
| instance = self.from_model(model, dataset=self.dataset) | ||
| self.__dict__ = instance.__dict__ |
There was a problem hiding this comment.
This is the only known way to update the internal instance state. The record from_model has complex mapping logic to build the record resource properly
frascuchon
commented
Sep 17, 2024
Comment on lines
+281
to
+290
| @property | ||
| def _client(self) -> Optional["Argilla"]: | ||
| if self._dataset: | ||
| return self.dataset._client | ||
|
|
||
| @property | ||
| def _api(self) -> Optional["RecordsAPI"]: | ||
| if self._client: | ||
| return self._client.api.records | ||
|
|
There was a problem hiding this comment.
To align the Resource interface definition
jfcalvo
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support to refresh a
rg.Recordfrom the server, allowing load responses, suggestions and vectors.Type of change
How Has This Been Tested
Checklist