Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PyGObject to known modules. #24

Closed
wants to merge 1 commit into from
Closed

Add PyGObject to known modules. #24

wants to merge 1 commit into from

Conversation

Dreamsorcerer
Copy link
Contributor

Not sure if this should be all lowercase, or match PyPI which lists it as "PyGObject".
I'm assuming the code will match it case-insensitively. Though, maybe it's a better idea to show the PyPI case in the error output?

Verified

This commit was signed with the committer’s verified signature.
KiteAB K1t3AB
@arkq arkq closed this in a3dcfde May 30, 2020
@arkq
Copy link
Owner

arkq commented May 30, 2020

No, it's not necessary to keep letter case. Thanks, for this PR.

Though, maybe it's a better idea to show the PyPI case in the error output?

Maybe it's a good idea, but right now output is based on import name, not package name.

@Dreamsorcerer
Copy link
Contributor Author

Oh, that's a shame, as most developers using pygobject will probably find it is already pre-installed, and they just import gi without knowing what the package name is. They'll probably have to do a search to even figure out what the name is, though not a major issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants