Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin ovsx as a dev dependency #631

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Pin ovsx as a dev dependency #631

merged 1 commit into from
Oct 18, 2024

Conversation

dhruvmanila
Copy link
Member

Summary

The recent version of ovsx had a breaking change which bumps the minimum Node version required to be 20. This broke our release workflow: https://github.com/astral-sh/ruff-vscode/actions/runs/11392480125/job/31698800337.

Similar to how we've pinned the @vscode/vsce which is a VS Code extension manager and is used to publish the artifacts to the VS Code Marketplace, we'll pin the ovsx as a dev dependency. Both had a breaking change but as the latter wasn't pinned, it used the latest version in CI.

Currently, the ovsx is pinned to 0.9.4 as 0.9.5 had the breaking change: https://github.com/eclipse/openvsx/blob/master/cli/CHANGELOG.md#v095-sep-2024

Test Plan

npx ovsx --version should give 0.9.4

Details

just clean
rm -rf out
rm -rf node_modules
rm -rf .vscode-test
rm -rf bundled/libsnpx ovsx --version
Need to install the following packages:
[email protected]
Ok to proceed? (y) y

0.10.0npx ovsx --version
0.10.0npm ci            
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported

added 531 packages, and audited 532 packages in 2s

116 packages are looking for funding
  run `npm fund` for details

5 vulnerabilities (3 moderate, 2 high)

To address all issues, run:
  npm audit fix

Run `npm audit` for details.npx ovsx --version
0.9.4

@MichaReiser
Copy link
Member

It's a bit unfortunate that the result is that everyone has to install ovsx which is only used in CI. an alternative is to use npx -y [email protected] but it comes with the downside that renovate won't upgrade it.

Either way. Should we upgrade our CI job to use something newer than node 20?

@dhruvmanila
Copy link
Member Author

It's a bit unfortunate that the result is that everyone has to install ovsx which is only used in CI. an alternative is to use npx -y [email protected] but it comes with the downside that renovate won't upgrade it.

Yeah, I initially thought of specifying the version directly in the workflow file but this was the reason I didn't do so.

Either way. Should we upgrade our CI job to use something newer than node 20?

Yes, I can do that in a follow-up PR.

@MichaReiser MichaReiser added the internal An internal refactor or improvement label Oct 18, 2024
@dhruvmanila dhruvmanila merged commit a8075e2 into main Oct 18, 2024
6 checks passed
@dhruvmanila dhruvmanila deleted the dhruv/ovsx branch October 18, 2024 06:42
dhruvmanila added a commit that referenced this pull request Oct 22, 2024
## Summary

This PR updates the minimum Node version to 22 and is a follow-up from
#631. The dependencies that
we use to publish the build artifacts bumped the minimum version of Node
to 20. I've bumped it to 22 as that's the minimum active LTS version
right now.

Along with the node version bump, this PR also updates the said
dependencies (`ovsx` and `vsce`) to the latest version which requires a
minimum node version of 20.

## Test Plan

When I perform the next release :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants