Extend pytest-raises-with-multiple-statements (PT012) to cover pytest.warns

[harupy]

pytest-raises-with-multiple-statements only covers pytest.raises. It'd be nice if it covers pytest.warns as well.

import pytest


def test_raises():
    with pytest.raises(Exception):  # PT012
        f3()
        f4()


def test_warns():
    with pytest.warns(UserWarning):
        f1()  # does this warn?
        f2()  # or perhaps this one warns?
        # -> Not obvious which line warns.

Playground to ensure pytest.warns is not covered: https://play.ruff.rs/271e2f8e-751a-4368-971c-322eeeb10b39

References:

• https://docs.pytest.org/en/stable/reference/reference.html#pytest.warns

[harupy]

Adding a new rule is another option.

[MichaReiser]

I think that would have to be its own rule unless we rename the existing rule

[harupy]

I think that would have to be its own rule unless we rename the existing rule

Makes sense.

[harupy]

@MichaReiser do we need to add the same rule in https://github.com/m-burst/flake8-pytest-style to add it in ruff?

[MichaReiser]

I think it should be fine. We just need to make sure that we use a rule code that's unlikely to collide with any new rule added to the upstream plugin

[tjkuson]

Created an issue in the upstream repo: m-burst/flake8-pytest-style#317

[MichaReiser]

Thanks @tjkuson

[snowdrop4]

This lint makes a lot of sense to me.

I'll make a draft branch.

I'll just use a placeholder rule code until the flake8 plugin decides on one.

There could also be pytest.warns versions of PT010 and PT011 (not just PT012), since they are all analagous.

[snowdrop4]

I have a finished branch: https://github.com/snowdrop4/ruff/tree/AVK/PytestWarnsWithMultipleStatements

But yeah, I'll wait and see what the flake8 plugin people say before PRing.

[MichaReiser]

The upstream issue has been closed as completed in case someone's interested to work on this

[tjkuson]

I volunteer unless @snowdrop4 fancies it