Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flake8-logging] Implement root-logger-calls (LOG015) #14302

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

InSyncWithFoo
Copy link
Contributor

Summary

Part of #7248.

Test Plan

cargo nextest run and cargo insta test.

Copy link
Contributor

github-actions bot commented Nov 13, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+284 -0 violations, +0 -0 fixes in 4 projects; 50 projects unchanged)

apache/superset (+52 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ superset/migrations/versions/2016-05-27_15-03_1226819ee0e3_fix_wrong_constraint_on_table_columns.py:64:9: LOG015 `warning()` call on root logger
+ superset/migrations/versions/2016-09-15_08-48_65903709c321_allow_dml.py:43:9: LOG015 `exception()` call on root logger
+ superset/migrations/versions/2016-09-22_10-21_3b626e2a6783_sync_db_with_models.py:116:9: LOG015 `warning()` call on root logger
+ superset/migrations/versions/2016-09-22_10-21_3b626e2a6783_sync_db_with_models.py:128:9: LOG015 `warning()` call on root logger
+ superset/migrations/versions/2016-09-22_10-21_3b626e2a6783_sync_db_with_models.py:135:9: LOG015 `warning()` call on root logger
+ superset/migrations/versions/2016-09-22_10-21_3b626e2a6783_sync_db_with_models.py:63:9: LOG015 `warning()` call on root logger
+ superset/migrations/versions/2016-09-22_10-21_3b626e2a6783_sync_db_with_models.py:72:9: LOG015 `warning()` call on root logger
+ superset/migrations/versions/2016-09-22_10-21_3b626e2a6783_sync_db_with_models.py:77:9: LOG015 `warning()` call on root logger
+ superset/migrations/versions/2016-09-22_10-21_3b626e2a6783_sync_db_with_models.py:83:9: LOG015 `warning()` call on root logger
+ superset/migrations/versions/2016-09-22_10-21_3b626e2a6783_sync_db_with_models.py:91:9: LOG015 `warning()` call on root logger
... 42 additional changes omitted for project

bokeh/bokeh (+5 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ scripts/milestone.py:33:9: LOG015 `debug()` call on root logger
+ scripts/milestone.py:41:9: LOG015 `debug()` call on root logger
+ src/bokeh/document/document.py:377:17: LOG015 `warning()` call on root logger
+ src/bokeh/io/notebook.py:581:5: LOG015 `debug()` call on root logger
+ src/bokeh/io/notebook.py:582:5: LOG015 `debug()` call on root logger

rotki/rotki (+4 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ rotkehlchen/__main__.py:28:13: LOG015 `critical()` call on root logger
+ rotkehlchen/__main__.py:33:9: LOG015 `critical()` call on root logger
+ rotkehlchen/exchanges/htx.py:183:21: LOG015 `debug()` call on root logger
+ rotkehlchen/logging.py:66:9: LOG015 `log()` call on root logger

zulip/zulip (+223 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ analytics/views/stats.py:485:13: LOG015 `warning()` call on root logger
+ scripts/lib/setup_venv.py:203:13: LOG015 `warning()` call on root logger
+ tools/lib/provision.py:90:5: LOG015 `critical()` call on root logger
+ zerver/actions/create_realm.py:194:9: LOG015 `info()` call on root logger
+ zerver/actions/invites.py:117:5: LOG015 `log()` call on root logger
+ zerver/actions/message_send.py:1901:9: LOG015 `exception()` call on root logger
+ zerver/actions/message_send.py:516:13: LOG015 `error()` call on root logger
+ zerver/actions/realm_settings.py:574:9: LOG015 `warning()` call on root logger
+ zerver/actions/scheduled_messages.py:378:5: LOG015 `info()` call on root logger
+ zerver/actions/scheduled_messages.py:395:17: LOG015 `info()` call on root logger
+ zerver/actions/scheduled_messages.py:400:17: LOG015 `exception()` call on root logger
+ zerver/actions/uploads.py:61:13: LOG015 `warning()` call on root logger
+ zerver/apps.py:12:5: LOG015 `info()` call on root logger
+ zerver/data_import/import_util.py:589:5: LOG015 `info()` call on root logger
+ zerver/data_import/import_util.py:590:5: LOG015 `info()` call on root logger
+ zerver/data_import/import_util.py:621:5: LOG015 `info()` call on root logger
+ zerver/data_import/import_util.py:632:9: LOG015 `exception()` call on root logger
+ zerver/data_import/import_util.py:638:5: LOG015 `info()` call on root logger
+ zerver/data_import/import_util.py:646:17: LOG015 `info()` call on root logger
+ zerver/data_import/import_util.py:670:5: LOG015 `info()` call on root logger
+ zerver/data_import/import_util.py:671:5: LOG015 `info()` call on root logger
+ zerver/data_import/import_util.py:682:5: LOG015 `info()` call on root logger
+ zerver/data_import/import_util.py:723:5: LOG015 `info()` call on root logger
+ zerver/data_import/import_util.py:724:5: LOG015 `info()` call on root logger
+ zerver/data_import/import_util.py:744:13: LOG015 `warning()` call on root logger
+ zerver/data_import/import_util.py:767:5: LOG015 `info()` call on root logger
+ zerver/data_import/mattermost.py:245:17: LOG015 `info()` call on root logger
+ zerver/data_import/mattermost.py:695:9: LOG015 `warning()` call on root logger
+ zerver/data_import/mattermost.py:750:5: LOG015 `info()` call on root logger
+ zerver/data_import/mattermost.py:801:5: LOG015 `info()` call on root logger
+ zerver/data_import/rocketchat.py:277:5: LOG015 `info()` call on root logger
+ zerver/data_import/rocketchat.py:334:5: LOG015 `info()` call on root logger
+ zerver/data_import/rocketchat.py:391:9: LOG015 `info()` call on root logger
+ zerver/data_import/rocketchat.py:395:9: LOG015 `info()` call on root logger
+ zerver/data_import/rocketchat.py:409:9: LOG015 `info()` call on root logger
+ zerver/data_import/rocketchat.py:413:9: LOG015 `info()` call on root logger
+ zerver/data_import/rocketchat.py:662:13: LOG015 `info()` call on root logger
+ zerver/data_import/rocketchat.py:729:17: LOG015 `info()` call on root logger
+ zerver/data_import/rocketchat.py:766:21: LOG015 `info()` call on root logger
... 184 additional changes omitted for project

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
LOG015 284 284 0 0 0

@MichaReiser MichaReiser added rule Implementing or modifying a lint rule preview Related to preview mode features labels Nov 13, 2024
Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Did you review the ecosystem changes?

@InSyncWithFoo
Copy link
Contributor Author

Did you review the ecosystem changes?

I did. They all seem to be true positives.

@MichaReiser MichaReiser enabled auto-merge (squash) November 13, 2024 09:09
@MichaReiser MichaReiser merged commit f789b12 into astral-sh:main Nov 13, 2024
19 checks passed
@InSyncWithFoo InSyncWithFoo deleted the LOG015 branch November 13, 2024 09:42
@dhruvmanila dhruvmanila changed the title [flake8-logging] Root logger calls (LOG015) [flake8-logging] Implement root-logger-calls (LOG015) Nov 15, 2024
@qartik qartik mentioned this pull request Nov 16, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Related to preview mode features rule Implementing or modifying a lint rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants