Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only flag flake8-trio rule when trio is present #8550

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Only flag flake8-trio rule when trio is present #8550

merged 1 commit into from
Nov 7, 2023

Conversation

charliermarsh
Copy link
Member

Summary

Hoping to avoid some false positives by narrowing the scope of #8534.

@charliermarsh charliermarsh added the bug Something isn't working label Nov 7, 2023
@charliermarsh charliermarsh changed the title Only flag TRIO109 when trio is present Only flag flake8-trio rule when trio is present Nov 7, 2023
@charliermarsh charliermarsh enabled auto-merge (squash) November 7, 2023 22:20
@charliermarsh charliermarsh merged commit 71e93a9 into main Nov 7, 2023
16 checks passed
@charliermarsh charliermarsh deleted the charlie/trio branch November 7, 2023 22:27
@zanieb
Copy link
Member

zanieb commented Nov 7, 2023

Seems wise!

@charliermarsh
Copy link
Member Author

@zanieb - We could consider doing the same thing with the Pandas rules.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2023

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@miccal miccal mentioned this pull request Nov 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charliermarsh @zanieb