-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(🐞) Add the missing period in error message #9485
Conversation
CodSpeed Performance ReportMerging #9485 will improve performances by 4.55%Comparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
)), | ||
"__getattribute__" => Some(Self::MessageOnly( | ||
"Access attribute directly or use getattr built-in function.", | ||
"Access attribute directly or use getattr built-in function", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing that I did a search and replace here to remove the periods but missed all the variants that are on their own line :)
|
code | total | + violation | - violation | + fix | - fix |
---|---|---|---|---|---|
PLC2801 | 400 | 200 | 200 | 0 | 0 |
Summary
I noticed that there should be a missing period added to some of the new error messages for Unnecessary dunder call:
Test Plan
Static analysis of the implementation, as this has no existing test cases.