Skip to content

Make show-settings filters directory-agnostic #9866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
charliermarsh merged 2 commits into from
Feb 7, 2024
Merged

Make show-settings filters directory-agnostic #9866

charliermarsh merged 2 commits into from
Feb 7, 2024

Conversation

@charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented Feb 6, 2024

Closes #9864.

@charliermarsh charliermarsh added the bug Something isn't working label Feb 6, 2024
@charliermarsh
Copy link
Member Author

charliermarsh commented Feb 6, 2024

(This will require some CI iteration for Windows.)

@charliermarsh charliermarsh force-pushed the charlie/filters branch 4 times, most recently from 922d900 to a736d49 Compare February 6, 2024 22:15
@charliermarsh charliermarsh force-pushed the charlie/filters branch 4 times, most recently from 3f48cab to be4ea99 Compare February 6, 2024 22:57
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@konstin @charliermarsh
Use display on windows
33aa1fc 
This avoids two backslashes in the output because the debug escape backslashes
@charliermarsh charliermarsh marked this pull request as ready for review February 7, 2024 03:14
@charliermarsh charliermarsh enabled auto-merge (squash) February 7, 2024 03:14
@charliermarsh charliermarsh merged commit e9ddd48 into main Feb 7, 2024
@charliermarsh charliermarsh deleted the charlie/filters branch February 7, 2024 03:20
@charliermarsh
Copy link
Member Author

charliermarsh commented Feb 7, 2024

(Merging since coauthored with @konstin.)

@Porkepix Porkepix mentioned this pull request Feb 18, 2024
Merged
nkxxll pushed a commit to nkxxll/ruff that referenced this pull request Mar 10, 2024
@charliermarsh @nkxxll
Make show-settings filters directory-agnostic (astral-sh#9866)
4b70006 
Closes astral-sh#9864.
@johnslavik johnslavik mentioned this pull request Mar 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test display_default_settings fails downstream

3 participants

@charliermarsh @konstin