Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MutationObserver for JSPM example #768

Merged
merged 1 commit into from
Jul 30, 2017

Conversation

nashwaan
Copy link
Contributor

Removed old reference of MutationObserver from previous doc (existed in JSPM example) and replaced it with the new shim:
Old doc instructed to install webcomponents/webcomponentsjs/MutationObserver.
But new doc uses mutationobserver-shim/MutationObserver. However, a trace of old shim existed in JSPM code.
Also, provided an example how to use the polyfill file in the webpack.config.js.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Removed old reference of MutationObserver from previous doc (existed in JSPM example) and replaced it with the new shim:
Old doc instructed to install `webcomponents/webcomponentsjs/MutationObserver`.
But new doc uses `mutationobserver-shim/MutationObserver`. However, a trace of old shim existed in JSPM code.
@AshleyGrant
Copy link
Collaborator

Looks good to me. @niieani or @jods4 would you mind reviewing the webpack config provided?

@jods4
Copy link
Contributor

jods4 commented May 1, 2017

Yeah, sorry I wanted to tackle the polyfills subject for a while but I haven't gotten to do it.

Although it's intuitive, I don't feel good with that config because it's not the first thing that will actually run.
Aurelia Webpack plugin will add a few modules in front of that, notably aurelia-polyfills and aurelia-webpack-loader.

I'll try to do something about it soon-ish.

@EisenbergEffect
Copy link
Contributor

@nashwaan There seems to be some contention over the Webpack configuration. I'm going to close this PR, but could you submit another one that just fixes the SystemJS usage and then we can work out the Webpack update separately? Thanks!

@jods4
Copy link
Contributor

jods4 commented Jul 30, 2017

The just-released RC3 version of Webpack plugin has changed this unintuitive behavior.

The code in this PR is now actually working as expected, which was not the case in RC2.

@EisenbergEffect
Copy link
Contributor

So, just to confirm. We should merge this now, correct?

@jods4
Copy link
Contributor

jods4 commented Jul 30, 2017

As far as the webpack config goes, I have no objection anymore.

@EisenbergEffect EisenbergEffect merged commit 52350c1 into aurelia:master Jul 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants