Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(786) documentation says export instead of exports #787

Merged
merged 1 commit into from
Aug 20, 2017

Conversation

Anthony-Mckale
Copy link
Contributor

I'm submitting a bug fix

Current behavior:

http://aurelia.io/hub.html#/doc/article/aurelia/framework/latest/bundling-jspm/9

{
"name":"jquery",
"path":"../node_modules/jquery/dist",
"main":"jquery.min",
"export": "$"
}
is incorrect

Expected/desired behavior:

{
"name":"jquery",
"path":"../node_modules/jquery/dist",
"main":"jquery.min",
"exports": "$"
}
as per http://requirejs.org/docs/api.html

What is the motivation / use case for changing the behavior?
avoid confusion for folks using old libraries

@Anthony-Mckale
Copy link
Contributor Author

#786 fix for this ticket

@EisenbergEffect
Copy link
Contributor

@JeroenVinke Can you confirm whether this change is correct or not?

@JeroenVinke
Copy link
Collaborator

Yep, looks good! I actually didn't notice this PR and made one myself for exactly the same: #816. That one i've closed so we can merge this

@EisenbergEffect EisenbergEffect merged commit a9404f2 into aurelia:master Aug 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants