Load neps arguments from a .yaml file using a new argument run_args #61
Conversation
danrgll
commented
Mar 11, 2024
•
- Integrating run_args, loading and checking settings from yaml file provided via run_args
- Tests for functionality
- Example usage in neps examples
- Documentation
…tting all other arguments that are provided via neps.run(...) + Enable loading the pipeline_space provided as a dictionary from YAML and the loading of the BaseOptimizer as searcher from YAML
…s.yaml to provide arguments + comment code
…extension + general improved error feedback
There was a problem hiding this comment.
Overall, some minor comments and I did not review the documentation.
I think you put a bit too much effort in documenting everything in the tests which is nice but save your effort for other parts!
The main things I identified to move towards merging this would be first to just explicitly not allow merging yaml parameters and function parameters. Yes it might be nice but not worth blocking on. We can revisit if necessary. Please raise an issue referencing this PR. You can use #<number> to refer to a specific issue or PR.
# text...
Please see PR #61… usage information for providing pipeline_space to neps.run()
|
Heyo, please let me know when you'd be ready for another review and we can get to work mergining this and cleaning anything up in a follow up PR! |
|
I implemented the strict check, from my side we can merge this now. Then I will create a new branch on top of this for refactoring. |