Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] add provisioner examples with EBS #2284

Merged
merged 5 commits into from
Aug 12, 2022
Merged

[docs] add provisioner examples with EBS #2284

merged 5 commits into from
Aug 12, 2022

Conversation

FernandoMiguel
Copy link
Contributor

Signed-off-by: Fernando Miguel [email protected]

Fixes #1100

Description
adds provisioner examples with EBS

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

Adds two examples of provisioner with EBS volumes. One for Bottlerocket (root and data) and one with multiple EBS

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@FernandoMiguel
add provisioner examples with EBS
1981a77 
Signed-off-by: Fernando Miguel <[email protected]>
@FernandoMiguel FernandoMiguel requested a review from a team as a code owner August 11, 2022 18:26
@FernandoMiguel FernandoMiguel requested a review from tzneal August 11, 2022 18:26
@netlify
Copy link

netlify bot commented Aug 11, 2022 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 457ce58
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/62f6606daef8d9000806fa25

@FernandoMiguel FernandoMiguel mentioned this pull request Aug 11, 2022
Closed
FernandoMiguel and others added 3 commits August 12, 2022 10:36
@FernandoMiguel @bwagner5
use AL2
75ef996 
Co-authored-by: Brandon Wagner <[email protected]>
@FernandoMiguel @bwagner5
remove tags
a565537 
Co-authored-by: Brandon Wagner <[email protected]>
@FernandoMiguel @bwagner5
set disk space instead of var
8630c5e 
Co-authored-by: Brandon Wagner <[email protected]>
@FernandoMiguel
Copy link
Contributor Author

ready for review

bwagner5
bwagner5 requested changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment on something I missed yesterday. Everything else looks good! Thanks!

examples/provisioner/multiple-ebs.yaml Outdated Show resolved Hide resolved
bwagner5
bwagner5 approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks for adding these @FernandoMiguel !!!

@bwagner5 bwagner5 merged commit d1d6e0e into aws:main Aug 12, 2022
@FernandoMiguel FernandoMiguel deleted the add-examples-with-EBS branch November 8, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blackliner blackliner blackliner left review comments

@bwagner5 bwagner5 bwagner5 approved these changes

@tzneal tzneal Awaiting requested review from tzneal tzneal is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

disk size setting
3 participants
@FernandoMiguel @bwagner5 @blackliner