Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix bottlerocket node template for GPU volume size #2400

Merged
merged 3 commits into from
Aug 31, 2022

Conversation

lamdor
Copy link
Contributor

@lamdor lamdor commented Aug 30, 2022

Description

the GPU bottlerocket AMI requires at least 3GB. otherwise you run into:

2022-08-30T13:27:52.897Z ERROR controller.provisioning Provisioning failed, launching node, creating cloud provider instance, with fleet error(s), InvalidBlockDeviceMapping: Volume of size 3GB is smaller than snapshot 'snap-0c5c999fe56c48b6f', expect size >= 4GB {"commit": "639756a"}

The normal bottlerocket AMI size is still 2GB, just GPU is a bit bigger.

There was also a typo with the volume size value.

How was this change tested?

  • N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

the GPU bottlerocket AMI requires at least 3GB. otherwise you run into:

> 2022-08-30T13:27:52.897Z        ERROR   controller.provisioning Provisioning failed, launching node, creating cloud provider instance, with fleet error(s), InvalidBlockDeviceMapping: Volume of size 3GB is smaller than  snapshot 'snap-0c5c999fe56c48b6f', expect size >= 4GB        {"commit": "639756a"}

The normal bottlerocket AMI size is still 2GB, just GPU is a bit bigger.

There was also a typo with the volume size value.
@lamdor lamdor requested a review from a team as a code owner August 30, 2022 14:04
@lamdor lamdor requested a review from tzneal August 30, 2022 14:04
@netlify
Copy link

netlify bot commented Aug 30, 2022

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit aa128de
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/630e263e3b59b0000a433c8e

@@ -23,7 +23,7 @@ spec:
- deviceName: /dev/xvda
ebs:
volumeType: gp3
volumeSize: 2Gi
volumeSize: 2G # if using GPU, replace with 4G since the GPU bottlerocket AMI requires at least 4G
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gi is the correct format, right?
the typo is in the one with 20GiBs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right... but helps if we align with what AWS EC2 and AMIs provide.
If EBSs with 20 gigabytes are 20Gi, that is what I feel we should use, since if we were to use 20G, the volume would be smaller than the AMI and fail.

Similar for RAM. If an ec2 has 16 gigabytes of RAM, using 16G is better than Gi ?

and yeah, I'm aware that HDD and SSD use base 2 and base 10 each.... OEMs ....

Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants