Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add EventRecorder to allocatable-diff cloud provider #4519

Merged
merged 1 commit into from
Aug 30, 2023
Merged

chore: add EventRecorder to allocatable-diff cloud provider #4519

merged 1 commit into from
Aug 30, 2023

Conversation

engedaam
Copy link
Contributor

Fixes #N/A

Description

  • Adding op.EventRecored to a new instantiation of a cloud provider

How was this change tested?

  • N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner August 30, 2023 23:19
@engedaam engedaam requested a review from njtran August 30, 2023 23:19
@netlify
Copy link

netlify bot commented Aug 30, 2023 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit c8affd1
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/64efd0f5fca3d1000860b3f5

njtran
njtran previously approved these changes Aug 30, 2023
View reviewed changes
@engedaam engedaam enabled auto-merge (squash) August 30, 2023 23:21
@engedaam engedaam disabled auto-merge August 30, 2023 23:30
@engedaam engedaam enabled auto-merge (squash) August 30, 2023 23:39
@engedaam engedaam merged commit a5ab4d3 into aws:main Aug 30, 2023
11 checks passed
@engedaam engedaam deleted the fix-allocatable-diff branch August 30, 2023 23:42
@aws aws locked and limited conversation to collaborators Oct 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@njtran njtran njtran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@engedaam @njtran