Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add support for v1beta1/NodeClaim garbage collection #4544

Merged

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Sep 1, 2023

Fixes #N/A

Description

This change adds support for the v1beta1/NodeClaim in the Machine garbage collection controller that currently only handles v1alpha5/Machine. This change stages out the v1beta1 changes so that the v1beta1 APIs can be released at a later time.

How was this change tested?

make presubmit
/karpenter snapshot

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner September 1, 2023 23:55
@netlify
Copy link

netlify bot commented Sep 1, 2023

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit f44ddcc
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/64f27e955588100008211e4a

Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023

Snapshot successfully published to oci://public.ecr.aws/karpenter/karpenter:v0-e26fb0016805f52c0a28e8763e5f022d372e7c61. Find the image tag and installation instructions at https://gallery.ecr.aws/karpenter/karpenter/

@jonathan-innis jonathan-innis force-pushed the v1beta1-machine-garbagecollection branch from e26fb00 to f44ddcc Compare September 2, 2023 00:15
@jonathan-innis jonathan-innis enabled auto-merge (squash) September 2, 2023 00:15
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023

Snapshot successfully published to oci://public.ecr.aws/karpenter/karpenter:v0-f44ddcccd15f4c89eb04b8dc16681208d3e3bf56. Find the image tag and installation instructions at https://gallery.ecr.aws/karpenter/karpenter/

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonathan-innis jonathan-innis merged commit 8159aea into aws:main Sep 5, 2023
@aws aws locked and limited conversation to collaborators Oct 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants