Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add test for instance profile tags #7363

Merged
merged 2 commits into from
Nov 13, 2024
Merged

test: Add test for instance profile tags #7363

merged 2 commits into from
Nov 13, 2024

Conversation

jigisha620
Copy link
Contributor

Fixes #N/A

Description
This PR adds a test which ensures that no instance profile tags are added if InstanceProfileTags() returns empty map.

How was this change tested?
make verify

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jigisha620 jigisha620 requested a review from a team as a code owner November 12, 2024 02:34
@netlify Netlify
Copy link

netlify bot commented Nov 12, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit eef6448
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6733ce081b1c490008c968ea

@coveralls
Copy link

coveralls commented Nov 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11806346104

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 82.686%
Files with Coverage Reduction New Missed Lines %
pkg/fake/utils.go 2 94.56%
Totals Coverage Status
Change from base Build 11805307907: -0.02%
Covered Lines: 5664
Relevant Lines: 6850
💛 - Coveralls

jonathan-innis
jonathan-innis previously approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

pkg/test/nodeclass.go Outdated Show resolved Hide resolved
jonathan-innis
jonathan-innis approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit edf80b0 into aws:main Nov 13, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@danxwang22 danxwang22 Awaiting requested review from danxwang22 danxwang22 is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jigisha620 @coveralls @jonathan-innis