Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing nodeclaim and nodeclass to UpdateInstanceTypeCapacityFromNode #7374

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

edibble21
Copy link
Contributor

… from controller

Fixes #N/A

Description
Passing nodeclaim and nodeclass to UpdateInstanceTypeCapacityFromNode from controller
How was this change tested?
make presubmit
Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@edibble21 edibble21 requested a review from a team as a code owner November 13, 2024 18:57
Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 925fc60
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6734f68d79159300084a3473
😎 Deploy Preview https://deploy-preview-7374--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 0d57916
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6734f6afcf07fe000894a0a6

@coveralls
Copy link

coveralls commented Nov 13, 2024

Pull Request Test Coverage Report for Build 11823955936

Details

  • 6 of 10 (60.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 82.684%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/providers/instancetype/capacity/controller.go 5 9 55.56%
Files with Coverage Reduction New Missed Lines %
pkg/fake/utils.go 2 94.56%
Totals Coverage Status
Change from base Build 11805307907: -0.02%
Covered Lines: 5663
Relevant Lines: 6849

💛 - Coveralls

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@edibble21 edibble21 merged commit 5910b7d into aws:main Nov 13, 2024
17 checks passed
@edibble21 edibble21 deleted the capacitychange branch November 13, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants