Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: version log change #7401

Merged
merged 7 commits into from
Nov 21, 2024
Merged

Chore: version log change #7401

merged 7 commits into from
Nov 21, 2024

Conversation

edibble21
Copy link
Contributor

Fixes #N/A

Description
Made Version provider less noisy by changing logs
How was this change tested?
make presubmit
Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@edibble21 edibble21 requested a review from a team as a code owner November 18, 2024 17:32
@edibble21 edibble21 requested a review from ellistarn November 18, 2024 17:32
Copy link

netlify bot commented Nov 18, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 84d447a
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/673e8366badbd20008d0b7d5

@coveralls
Copy link

coveralls commented Nov 18, 2024

Pull Request Test Coverage Report for Build 11944422780

Details

  • 4 of 5 (80.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 82.451%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/providers/version/version.go 4 5 80.0%
Totals Coverage Status
Change from base Build 11924046371: 0.002%
Covered Lines: 5685
Relevant Lines: 6895

💛 - Coveralls

engedaam
engedaam previously approved these changes Nov 18, 2024
engedaam
engedaam previously approved these changes Nov 18, 2024
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

pkg/providers/version/version.go Outdated Show resolved Hide resolved
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@edibble21 edibble21 merged commit 83f7c74 into aws:main Nov 21, 2024
17 checks passed
edibble21 added a commit to edibble21/karpenter-provider-aws that referenced this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants