Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore: Update data from AWS APIs (#7400)" #7447

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Nov 26, 2024

This reverts commit a4240fc.

Fixes #N/A

Description

We need to revert this change because the instances types added are not yet available in any released version of the vpc-resource-controller. The effect of this is that Karpenter is aware that these instances are trunking compatible, but the vpc-rc is not. The node will never initialize because the pod-eni resource aren't registered by vpc-rc because it believes it's incompatible.

How was this change tested?

  • N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner November 26, 2024 17:11
Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 01f3aa0
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6746015dd490310008a12cf5

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12035631951

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.022%

Totals Coverage Status
Change from base Build 12035171757: 0.0%
Covered Lines: 5733
Relevant Lines: 8817

💛 - Coveralls

Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit da9d4ef into aws:main Nov 26, 2024
17 checks passed
@engedaam engedaam deleted the revert-instance-type-data branch November 26, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants