Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error metadata missing on some interop call exceptions (#842) #843

Merged
merged 6 commits into from
Nov 28, 2022

Conversation

bobisageek
Copy link
Contributor

@bobisageek bobisageek commented Nov 27, 2022

Closes #842

Change details:

  • analyzer.cljc:
    • analyze-dot: the "big volume" change is letting stack once, since the proposal is to always include stack on the Nodes. The primary behavioral change is including stack on the Nodes that use get-static-field (not 100% sure if this is desired or not)
    • expand-dot*: include expr's meta on the expanded form
  • interop_test.cljc:
    • require clojure.string for clj as well as cljs (for checking exception message contents on both platforms)
    • add a test for various instance/member access notations and asserting that exception data is always present

Please answer the following questions and leave the below in as part of your PR.

@borkdude
Copy link
Collaborator

I'll take a look at this tomorrow

@borkdude borkdude merged commit 05c738b into babashka:master Nov 28, 2022
@borkdude
Copy link
Collaborator

Thanks!

@bobisageek bobisageek deleted the expand-dot-star-meta branch November 28, 2022 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error metadata missing on some interop calls
2 participants