Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed metadata for geospatial types (#2322) #2323

Conversation

Anikait143
Copy link
Contributor

Description

  • Fixed metadata for geospatial types:

  • Create Type - currently Babelfish supports it but TSQL doesn't for geospatial Types, Although it doesn't break anything and we will handle this case later

cherry-picked: #2322
Authored-by: Anikait Agrawal [email protected]
Signed-off-by: Anikait Agrawal [email protected]

Test Scenarios Covered

  • Use case based - TestSpatialPoint-vu-cleanup, TestSpatialPoint-vu-prepare, TestSpatialPoint-vu-verify

  • Boundary conditions -

  • Arbitrary inputs -

  • Negative test cases -

  • Minor version upgrade tests -

  • Major version upgrade tests -

  • Performance tests -

  • Tooling impact -

  • Client tests -

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Fixed metadata for geospatial types:
Create Type - currently Babelfish supports it but TSQL doesn't for geospatial Types, Although it doesn't break anything and we will handle this case later

Signed-off-by: Anikait Agrawal [email protected]
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7726325640

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.057%

Totals Coverage Status
Change from base Build 7722612041: 0.0%
Covered Lines: 40187
Relevant Lines: 55771

💛 - Coveralls

@shardgupta shardgupta merged commit 65debe3 into babelfish-for-postgresql:BABEL_4_X_DEV Jan 31, 2024
38 checks passed
@Anikait143 Anikait143 deleted the fix-metadata_4_X branch January 31, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants