Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store function arguments in catalog "babelfish_schema_permissions" #2355

Conversation

thephantomthief
Copy link
Contributor

@thephantomthief thephantomthief commented Feb 12, 2024

Description

Store function argument in the catalog babelfish_schema_permissions. Use that function argument while recreating GRANT statements at the time of REVOKE on SCHEMA statement in grant_perms_to_objects_in_schema.

Task: BABEL-4767
Signed-off-by: Sharu Goel [email protected]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

shalinilohia50 and others added 2 commits February 12, 2024 14:27
Store function argument in the catalog babelfish_schema_permissions.
Use that function argument while recreating GRANT statements at the time of REVOKE on SCHEMA statement in grant_perms_to_objects_in_schema.

Signed-off-by: Sharu Goel <[email protected]>
@coveralls
Copy link
Collaborator

coveralls commented Feb 12, 2024

Pull Request Test Coverage Report for Build 7873803055

Details

  • 0 of 24 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 72.591%

Totals Coverage Status
Change from base Build 7834190948: 0.006%
Covered Lines: 41021
Relevant Lines: 56510

💛 - Coveralls

@jsudrik jsudrik merged commit 69ce02a into babelfish-for-postgresql:BABEL_4_X_DEV Feb 13, 2024
38 checks passed
@shalinilohia50 shalinilohia50 deleted the sharu-dev-store-func-args-4x branch March 4, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants