Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose MessageLimit as a configuration #836

Closed
wants to merge 5 commits into from

Conversation

zhzy0077
Copy link
Contributor

Problem:
When sending long messages, the server returns

{
    "code": 41303,
    "http": 413,
    "error": "JSON body too large"
}

Changes:
Expose the MessageLimit as a configuration key so users can customize this value.

@binwiederhier
Copy link
Owner

I am willing to accept this as a config option if you document it properly in the config.md like the other options with a big fat warning around the fact that if a higher message limit is used with FCM or APNS, things will likely not work at all.

cmd/serve.go Outdated Show resolved Hide resolved
cmd/serve.go Outdated Show resolved Hide resolved
docs/config.md Outdated Show resolved Hide resolved
@zhzy0077
Copy link
Contributor Author

@binwiederhier Any other concerns of this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants