Fix condition for checking root logger handlers #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tkrille your argument is absolutely valid, I will tweak this a little bit more per your recommendation and release a new version |
|
1.2.6 release with your fix, thanks for the contribution |
bobbui
pushed a commit
that referenced
this pull request
Aug 5, 2020
|
You're very welcome. Thanks for the fast release :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to got broken when moving the condition upwards. Not a big issue, but it logs a wrong message, which is annoying :) I've also wondered if we should return from the method immediately, if the root logger has no handlers. At least that was more or less the behavior before moving up the conditional.