Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bootstrap-ruby/bootstrap_form
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.0.0
Choose a base ref
...
head repository: bootstrap-ruby/bootstrap_form
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.1.0
Choose a head ref

Commits on Nov 22, 2021

  1. Fix Rails Edge tests (#613)

    * Fix rubocop offenses
    
    * Run tests on all branches
    
    * Fetch rails edge from main branch
    
    Otherwise bundle gets confused and tries to get master
    
    * Include sassc-rails to add Rails.application.config.assets config
    
    * Fix tests for Rails 7
    
    - include autocomplete="off" for hidden fields
    - update rich_text_area test for direct upload
    
    * Fix unwanted skipping of test if Rails < 7
    
    - also restructures the test to make it a bit more readable
    thimo authored Nov 22, 2021

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    6d0f76d View commit details

Commits on Dec 28, 2021

  1. Allow overriding the default form_group class

    I think the default wrapper class, "mb-3", is good, but there should be a way to omit it while still rendering the label and the rest of the form group content.
    
    I realize this is an API change, but I think it is a good one which gives more power to the developers.  I also think it is in good alignment with the upstream bootstrap project.
    donv authored Dec 28, 2021

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    3ed3144 View commit details
  2. Revert "Allow overriding the default form_group class"

    This reverts commit 3ed3144.
    UweKubosch committed Dec 28, 2021
    Copy the full SHA
    bdfd061 View commit details
  3. Copy the full SHA
    297b6b6 View commit details
  4. Copy the full SHA
    772a142 View commit details
  5. Copy the full SHA
    b63dc9d View commit details
  6. Copy the full SHA
    e89534c View commit details
  7. Merge pull request #616 from bootstrap-ruby/fix_danger

    Use the generated token for this GH Actions run
    donv authored Dec 28, 2021

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    aeb6ffa View commit details
  8. Copy the full SHA
    712cc5a View commit details
  9. Start testing Ruby 3.1 and Rails 7.0

    UweKubosch authored and donv committed Dec 28, 2021
    Copy the full SHA
    46c680f View commit details
  10. Copy the full SHA
    5c01054 View commit details

Commits on Dec 30, 2021

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    af86a05 View commit details

Commits on Jan 3, 2022

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    c48b373 View commit details

Commits on Jan 8, 2022

  1. Rails 7.0.1 (#622)

    * cherry-pick .gitignore
    
    * Fix Rails to 7.0.1 for Ruby 3.1
    
    * Run CI
    
    * Run CI again
    lcreid authored Jan 8, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    9db677f View commit details
  2. Yarn dependabot (#623)

    * WIP installation doc
    
    * Update yarn dependencies
    The yarn security issues are only in the demo app, but it's still nice
    to get rid of the message.
    
    * Revert changes to README
    lcreid authored Jan 8, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    289f963 View commit details

Commits on Jan 9, 2022

  1. Allow omitting the wrapper class

    UweKubosch authored and donv committed Jan 9, 2022
    Copy the full SHA
    3ce4def View commit details
  2. Add Changelog.md entry

    UweKubosch authored and donv committed Jan 9, 2022
    Copy the full SHA
    17f6522 View commit details

Commits on Jan 10, 2022

  1. Demo 7.0 (#624)

    * WIP installation doc
    
    * Rails 7 demo app
    
    * Run Bootstrap from CDN
    
    * Update contributing docs for running Rails 7
    
    * Gemfile comment add 7.0
    
    * Add some notes to the documentation
    lcreid authored Jan 10, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    527bf8b View commit details
  2. Update package.json (#626)

    lcreid authored Jan 10, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    74ff189 View commit details

Commits on Jan 15, 2022

  1. Try fixing fork pRs

    donv committed Jan 15, 2022
    Copy the full SHA
    2e8ad70 View commit details

Commits on Jan 16, 2022

  1. Run fork pull requests with base workflow

    * Try using `pull_request_target` to fix fork PRs
    * Also use `secrets.GITHUB_TOKEN` instead of `github.token`
    * Add "danger" to the Gemfile for caching in CI
    donv authored Jan 16, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    e76a663 View commit details
  2. Copy the full SHA
    da134d4 View commit details
  3. Copy the full SHA
    e48d919 View commit details
  4. Copy the full SHA
    2c67906 View commit details
  5. Copy the full SHA
    44f611a View commit details
  6. Copy the full SHA
    a4365eb View commit details
  7. Copy the full SHA
    1c7688d View commit details
  8. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    c07c482 View commit details

Commits on Apr 21, 2022

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    47056da View commit details
  2. Copy the full SHA
    6980928 View commit details
  3. Copy the full SHA
    53e1679 View commit details
  4. Fix Rubocop offenses

    UweKubosch committed Apr 21, 2022
    Copy the full SHA
    c1818ae View commit details
  5. Copy the full SHA
    425c4d7 View commit details
  6. Copy the full SHA
    b9e5bf1 View commit details
  7. Copy the full SHA
    bd334ab View commit details
  8. show field's help message even on validation error (#300)

    Co-authored-by: Anton Pawlik <anton.pawlik@gmail.com>
    antpaw and Anton Pawlik authored Apr 21, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    98746c0 View commit details
  9. Copy the full SHA
    4ac88dc View commit details

Commits on Apr 22, 2022

  1. Update Demo app usage

    UweKubosch committed Apr 22, 2022
    Copy the full SHA
    3548d78 View commit details
  2. Copy the full SHA
    f25c1ed View commit details

Commits on Apr 23, 2022

  1. Fix rubocop offenses

    UweKubosch committed Apr 23, 2022
    Copy the full SHA
    09083ec View commit details
  2. Add example images to README.md (#635)

    Co-authored-by: Uwe Kubosch <uwe@datek.no>
    donv and UweKubosch authored Apr 23, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    5126f16 View commit details

Commits on Apr 24, 2022

  1. Add generated HTML for the examples in README.md (#636)

    Remove images for empty examples in README.md
    donv authored Apr 24, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    fec914e View commit details

Commits on Apr 25, 2022

  1. Copy the full SHA
    c0318db View commit details

Commits on Apr 28, 2022

  1. Use a bootstrap_form_for wrapper for README examples that display e…

    …rrors (#637)
    
    * Removed the wrapping `form` tag for examples that don't include the `bootstrap_form_for` wrapper
    * Added email to the standard user + help text in example 2
    donv authored Apr 28, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    8a9e34c View commit details
  2. Copy the full SHA
    9556955 View commit details
  3. rubocop fixes

    UweKubosch committed Apr 28, 2022
    Copy the full SHA
    e28245e View commit details
  4. Copy the full SHA
    42a3ad5 View commit details
  5. Copy the full SHA
    0157ee5 View commit details
  6. Copy the full SHA
    2b3a414 View commit details
  7. Copy the full SHA
    4f06e76 View commit details
Loading