Skip to content

Fix assets in the demo app #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 25, 2023
Merged

Conversation

lcreid
Copy link
Contributor

@lcreid lcreid commented Apr 23, 2023

The demo app was not working the way it should have: It was not actually using any local assets, and was just using stock Bootstrap from CDN. This meant we weren't able to try things like customizing Bootstrap in the demo app. It also wasn't properly including our local application.scss file.

It turned out to be a long adventure to fix this, which ended up including:

  • Regenerating the binstubs for all gems in the demo app. This didn't change anything as far as I can tell, but it shouldn't hurt to have these up-to-date.
  • Making many config and initialization files match (as closely as possible) the files from a freshly generated Rails 7 app, generated with rails new --skip-hotwire -d sqlite --edge -j esbuild -c bootstrap .. Again, this didn't seem to make much difference, but it's not a bad thing to have them more up-to-date.
  • Explicitly running the Rails server with bundle exec rails -s -b 0.0.0.0. I don't understand why the Rails in the bin directory wasn't doing this, but that's what fixed the problem of the assets not being processed.

@lcreid lcreid requested review from donv and thimo April 23, 2023 20:21
@lcreid lcreid marked this pull request as draft April 23, 2023 20:26
@lcreid lcreid force-pushed the fix-assets-in-demo branch from ed39f7f to fd68407 Compare April 24, 2023 03:38
@lcreid lcreid self-assigned this Apr 24, 2023
@lcreid lcreid marked this pull request as ready for review April 24, 2023 03:41
@lcreid lcreid merged commit 610a5c7 into bootstrap-ruby:main Apr 25, 2023
@donv donv mentioned this pull request May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants