Fix assets in the demo app #678
Merged
+11,472
−7,405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The demo app was not working the way it should have: It was not actually using any local assets, and was just using stock Bootstrap from CDN. This meant we weren't able to try things like customizing Bootstrap in the demo app. It also wasn't properly including our local
application.scss
file.It turned out to be a long adventure to fix this, which ended up including:
rails new --skip-hotwire -d sqlite --edge -j esbuild -c bootstrap .
. Again, this didn't seem to make much difference, but it's not a bad thing to have them more up-to-date.bundle exec rails -s -b 0.0.0.0
. I don't understand why the Rails in thebin
directory wasn't doing this, but that's what fixed the problem of the assets not being processed.