Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update crawler html selector for series page #102

Merged
merged 1 commit into from
Jan 17, 2020
Merged

Update crawler html selector for series page #102

merged 1 commit into from
Jan 17, 2020

Conversation

AmirRezaM75
Copy link
Collaborator

This PR fixes #100 .
Algolia result is not up to date; even in main website (laracasts) you can't get any result for "code katas in phpunit" or newer course like "javascript-techniques-for-server-side-developers".
And @carlosflorencio knews about that and he was scrapping series page and merging them with algolia result in App/Laracasts/Controller.php.
But query selector is out dated. I just update crawler filtering and it works fine.

@carlosflorencio
Copy link
Owner

Thanks @AmirRezaM75, once this is tested and confirmed working by someone else I'll merge it 💪.

@willvincent
Copy link
Contributor

Confirmed, this resolves this issue!

====================================
Authenticating
====================================
> Successfull!

====================================
Starting Collecting the data
====================================

====================================
Checking for options []
====================================
> No options provided

====================================
Downloading
====================================
> 0 new lessons and 2 episodes. 2.917s elapsed with 6.00Mb of memory usage.

@carlosflorencio
Copy link
Owner

Thanks for testing @willvincent, awesome work @AmirRezaM75.

@carlosflorencio carlosflorencio merged commit 60c876b into carlosflorencio:master Jan 17, 2020
@AmirRezaM75
Copy link
Collaborator Author

@carlosflorencio Your welcome <3

@AmirRezaM75 AmirRezaM75 deleted the update-crawler-filtering branch January 17, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No longer finding new downloads
3 participants