appengine: updating dependency paths and adding documentation #464
+123
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please review and let me know if this can be integrated. Thanks! |
|
I had to I update the Glide dependencies, and also subsequently updated the go_appengine SDK used with travis-ci. |
| - export PATH=$PATH:$PWD/go_appengine/ | ||
| - $PWD/go_appengine/goapp get github.com/stretchr/testify/require github.com/pborman/uuid golang.org/x/net/context # FIXME | ||
| # - $PWD/go_appengine/goapp get github.com/stretchr/testify/require github.com/pborman/uuid golang.org/x/net/context |
There was a problem hiding this comment.
You may safely remove this line if it works and runs the tests without it.
|
What is the |
|
The appengine/appengine binary is attached because I'm an idiot. I will fix this. |
|
I made the needed changes. Let me know if there is any other problems / issues. Again, thanks! |
Ran aefix against the gaedatastore and added some documentation to the appengine folder along with an example for deploying to the traditional and flexible environments.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran aefix against the gaedatastore and added some documentation to the
appengine folder along with an example for deploying to the traditional
and flexible environments.