Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ResourceWarning: unclosed file, in tests #21

Merged
merged 1 commit into from
Aug 18, 2018
Merged

Fix ResourceWarning: unclosed file, in tests #21

merged 1 commit into from
Aug 18, 2018
+10 −10

Conversation

BoboTiG
Copy link
Contributor

@BoboTiG BoboTiG commented Aug 18, 2018

Fixes 2 warnings in tests:

test_lsb.py:137 unclosed file <_io.BufferedReader name='./tests/sample-files/20160505T130442.jpg'>"
test_exifHeader.py:91 unclosed file <_io.BufferedReader name='./tests/sample-files/20160505T130442.jpg'>"

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.963% when pulling f9619a8 on BoboTiG:fix-resource-warnings into 041a4ee on cedricbonhomme:master.

@cedricbonhomme cedricbonhomme merged commit 9f2f739 into cedricbonhomme:master Aug 18, 2018
@cedricbonhomme
Copy link
Owner

Merged, thank you for the contribution!

@BoboTiG BoboTiG deleted the fix-resource-warnings branch August 18, 2018 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BoboTiG @coveralls @cedricbonhomme