Map research #11
Merged
Map research #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Faster lazy caching implementations of map and various details around chunking.
Turns out clojure.core/map is really inefficient when the sequence isn't itself chunked or what there are more than one collection passed in. The implementation in lazy-caching is many times faster I think in every situation - especially the latest versions which always do chunking but chunking is such a minefield - you are better off going with lazy-noncaching IMO as it is still element-by-element processing in most situations.
That being said it is important that contains to provide chunking seqs when possible to play well with the various functions in clojure core.