Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari #494

Closed
CorduroyZeus123 opened this issue Aug 15, 2020 · 35 comments
Closed

Safari #494

CorduroyZeus123 opened this issue Aug 15, 2020 · 35 comments
Labels
help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) List of tasks Efficient to have a List for this (sub-)project. (Each task might be worth an extra thread.) 🧩Plan ready Solution or some specification noted; To-Do; steps for implementation (+raw brainstorming too maybe) 💭Question🌱 Q & A (We can move it to the 'Discussions'-Section, if no other label applies) z Safari occuring in Safari (only?)

Comments

@CorduroyZeus123
Copy link

Love using this extension but also prefer using Safari for its speed and battery efficiency.

Would love it if you could make an extension that is compatible with Safari.

Happy to pay for it!

@Anoaxx
Copy link

Anoaxx commented Aug 15, 2020

What an emotional change between title and desc xD

@ghost ghost added the Feature request Wish or idea label Aug 15, 2020
@ImprovedTube
Copy link
Member

Hi! ♥ yes, we'd like to publish for Safari. Safari supports normal "Web Extensions". However they want them to be wrapped in an "app". Which requires a OSX command as follows: Apple Webextensions
If you can, please try it in Safari already. ImprovedTube-latest.zip

@CorduroyZeus123
Copy link
Author

Sorry, I have downloaded the zipped folder... What do I do next?

@ImprovedTube
Copy link
Member

ImprovedTube commented Aug 17, 2020

Cool! Unpack, then run that Xcode command in command line as in the screenshot
i.e.
xcrun safari-web-extension-converter /Users/You/Documents/unpackedStuff/
( or $HOME/ImprovedTube-master or drag and drop the folder as seen here @ 4:19 https://developer.apple.com/videos/play/wwdc2020/10665/ watch up to 2 minutes until 6:20 )

@CorduroyZeus123
Copy link
Author

Great, but how long would it take you to get an official app on the AppStore??

@CorduroyZeus123
Copy link
Author

So is there any chance of a safari extension application for mac??

@ImprovedTube
Copy link
Member

hi @CorduroyZeus123, does everything work for you in Safari? Did you identify difference compared to Chromium?

@CorduroyZeus123
Copy link
Author

Sorry, I don't really want to go through all of the hassles of unpacking the extension etc onto Safari, but I would be happy to use it if and when available on the AppStore and provide feedback.

@ImprovedTube
Copy link
Member

@CorduroyZeus123
oww, it's less of a hassle than opening github issue (=you might be done as fast as you can type the command)
(so you might be the noble first tester before >10000 people get it from store)
Alternatively you can sponsor the Appstore fee of $99/year 😆

@ghost ghost changed the title MAKE AN EXTENSION FOR SAFARI!!! Safari Sep 9, 2020
@CorduroyZeus123
Copy link
Author

I just unpacked the extension onto Safari, and it loaded perfectly fine. However, YouTube does not work at all with the extension on - an error continually occurs preventing any video from loading! In addition, the forced playback slider does not work. I would be happy to test out further extension updates if you send the zipped folder which I can then load onto Safari.

@CorduroyZeus123
Copy link
Author

Just unpacked the latest version of the extension onto Safari and it works much better! Here are a couple of things that need fixing:

  • Blocking all ads does not always work although does the majority of the time
  • Banner ads are not blocked at all
  • Autoplay when clicking a video doesn't work all the time
  • When you change a setting via the extension, it is not applied until the website is reloaded
  • The shortcuts to change the playback speed, when set, only allow changes up to 2x speed and cannot go faster using the shortcut
  • (The extension is unsigned so has to be allowed every time safari quits and opens - any way of permanently allowing unsigned extensions?)

Cheers

@CorduroyZeus123
Copy link
Author

*Forced playback doesn't actually work past 2x at all, whether the shortcut is enabled or not, even when set to higher forced playback speeds

@Venryx
Copy link
Contributor

Venryx commented Oct 4, 2020

I did work earlier to fix the playback speed being limited to x2, as well as making the playback-speed-setting code consistent between the three code-paths that perform that function. It was merged: #161

However, soon afterward (like a few days later), some other commits were added that overwrote (some of) my fixes, and messed up some other things as well. I wrote this comment explaining the situation, and how to fix it again: #27 (comment)

Unfortunately, the issue didn't end up getting re-opened, and no one followed up on what I could do to get the fixes re-merged. So after a few days, I gave up and started using a different extension for video-speed controlling: https://github.com/igrigorik/videospeed

Hopefully ImprovedTube will eventually get this issue fixed, but in the meantime you can use the extension above (or one of the others like it).

@ImprovedTube
Copy link
Member

ImprovedTube commented Oct 27, 2020

Thank you so much! @CorduroyZeus123 & @Venryx

@Venryx sorry this took long!! no good edits should be lost of course!

When you change a setting via the extension, it is not applied until the website is reloaded

Sounds like this is the only Safari-specific issue, to fix before publishing in Appstore

(The extension is unsigned so has to be allowed every time safari quits and opens - any way of permanently allowing unsigned extensions?)

good question. not in official documentation
https://developer.apple.com/documentation/safariservices/safari_app_extensions/building_a_safari_app_extension

@Raid13577
Copy link

👌🏻♥️

@ImprovedTube ImprovedTube added the help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) label Dec 13, 2020
@ImprovedTube ImprovedTube added the 🧩Plan ready Solution or some specification noted; To-Do; steps for implementation (+raw brainstorming too maybe) label Feb 14, 2021
@ImprovedTube ImprovedTube added not Goo. Chrome a bug that does not happen in Google Chrome. (Maybe look for the browser Labels starting with 'z') 💭Question🌱 Q & A (We can move it to the 'Discussions'-Section, if no other label applies) labels Apr 12, 2021
@ImprovedTube
Copy link
Member

ImprovedTube commented Apr 12, 2021

Safari version could have ** *** users already.
Sadly AppStore costs $99/year (& extra work)
If you sell it, you only get 70%.
So we should raise funds and publish a free link + sell at monthly price when found by store? - what is the cheapest possible?

@h3nk387
Copy link

h3nk387 commented May 19, 2021

I can pay for the App Store fee first year. People hate subscriptions so I think you should just sell it for like $0.99 or $1.99 max. That should get you more than enough funds to pay off the next year App Store fees and make a little well earned money for your work. :)

How do I easily send the money to you. How do we go about that? I'm not so familiar with GitHub. Is there a way to open a "chat" with you if we both follow each other or something?

@augustobob
Copy link

I failed in every attempt to convert it to safari, no matter what i do terminal gives me this message: "xcrun: error: unable to find utility "safari-web-extension-converter", not a developer tool or in PATH"

@andyayya
Copy link

andyayya commented Sep 2, 2021

Please add this to the App Store so it's available for Safari now that iPadOS 15 will bring extensions to iPad :(

I would suggest this extension to be "free" for people to install and use features like "hide recommendations and ads" but you have to pay to unlock speed/hide comments,etc. and all the other cool features. (If it's too much work just make it a paid app and call it a day)
Most people don't know that you can "hack youtube features" so making it free to install in the first place could show the premium features so they are more convinced to pay. I didn't know that an extension could to what this extension does and now I can't live without it 😅 I would pay 2$ with eyes closed hahaha I would recommend to some friends and are in the Apple ecosystem

@ImprovedTube ImprovedTube added the important Critical or common. Thus to prioritize label Jun 14, 2022
@augustobob
Copy link

Cool! Unpack, then run that Xcode command in command line as in the screenshot
i.e.
xcrun safari-web-extension-converter /Users/You/Documents/unpackedStuff/
( or $HOME/ImprovedTube-master or drag and drop the folder as seen here @ 4:19 https://developer.apple.com/videos/play/wwdc2020/10665/ watch up to 2 minutes until 6:20 )

I followed this instructions and finally succeeded to run with no errors, but then I got a folder with some other folders and no app to add the extension. what im doing wrong?
Captura de Tela 2022-08-29 às 20 16 12

@ImprovedTube ImprovedTube added this to the x in 1 milestone Sep 29, 2022
@ImprovedTube ImprovedTube removed the important Critical or common. Thus to prioritize label Oct 1, 2022
@ImprovedTube ImprovedTube moved this to Todo in Priority A Oct 1, 2022
@hboyd2003 hboyd2003 added z Safari occuring in Safari (only?) and removed not Goo. Chrome a bug that does not happen in Google Chrome. (Maybe look for the browser Labels starting with 'z') labels Oct 12, 2022
@TienTim
Copy link

TienTim commented Feb 9, 2023

@ImprovedTube May I distribute this app extension on the App Store?

@RobyRew
Copy link

RobyRew commented Feb 19, 2023

does someone have the .app?, we really don't need it to be on App Store, I can codesign the app so App Store is not necessary

Edit: Typo

@TienTim
Copy link

TienTim commented Mar 7, 2023

https://apps.apple.com/us/app/improved-tube/id1672777754

@ImprovedTube
Copy link
Member

Hi Guys! Please review @TienTim's upload to the AppStore as he proposed in #1568

@h3nk387 @RobyRew @CorduroyZeus123 @augustobob @GameParrot @andyayya @Raid13577

If we have an AppStore account later, as an organisation, then this App can be transfered in place.

many smiles!

@RobyRew
Copy link

RobyRew commented Mar 13, 2023

Hi Guys! Please review @TienTim's upload to the AppStore as he proposed in #1568

@h3nk387 @RobyRew @CorduroyZeus123 @augustobob @GameParrot @andyayya @Raid13577

If we have an AppStore account later, as an organisation, then this App can be transfered in place.

many smiles!

I have installed on my both Macs and too far too good is working, tomorrow ill review on AppStore,
for now I have a small issue, where I can report the bug?
Screen Shot 2023-03-13 at 19 59 52

as you can see the buttons are just super small and everything is disordered and some hidden.

@ImprovedTube
Copy link
Member

ImprovedTube commented Mar 13, 2023

Hi @RobyRew, thanks! With sidebar on the left only? (Or even with no features enabled?) Assumably thats our first a safari specific bug-report

Just uploaded the first big update since several month to the repo latest
@TienTim you can upload it (Wont ask often 😆) Thanks again!

@RobyRew
Copy link

RobyRew commented Mar 13, 2023

Hi @RobyRew, thanks! With sidebar on the left only? (Or even with no features enabled?) Assumably thats our first a safari specific bug-report

Just uploaded the first big update since several month to the repo latest @TienTim you can upload it (Wont ask often 😆) Thanks again!

It looks like its there anyway, I found why, its has something to do with (Return YouTube Dislike by Anarios & JRWR): https://github.com/Anarios/return-youtube-dislike/raw/main/Extensions/UserScript/Return%20Youtube%20Dislike.user.js

I have it installed with Tampermonkey, these settings control a little about the grey bar , im not sure what to do to fix Return Dislike Button.
image

Soo the extension ImprovedTube works perfectly, is the other extension that is conflicting with.

Youtube with ImprovedTube OFF, and Return Dislike Button ON:
image

Youtube with ImprovedTube ON, and Return Dislike Button OFF:
image

Youtube with ImprovedTube ON, and Return Dislike Button ON:
image

SUGGESTIONS?

@ImprovedTube
Copy link
Member

hi! @RobyRew try v4.2 😊

@RobyRew
Copy link

RobyRew commented Mar 17, 2023

hi! @RobyRew try v4.2 😊

Where's the .app, .dmg or xcodeProject? to download it?


Also, the app can work too even if its not on the App Store or not dev code signed, everyone can self code sign the app with this instructions:

  1. Create a local certificate called ImprovedTube-for-YouTube with code signing capability.
  2. Download the .app on /Download folder
  3. Open Terminal and run these commands:
    • cd /Download
    • macdeployqt Improved\ Tube.app -codesign=ImprovedTube-for-YouTube
  4. Copy the Improved Tube.app application package to Applications.

@ImprovedTube ImprovedTube removed the Feature request Wish or idea label May 1, 2023
@ImprovedTube
Copy link
Member

ImprovedTube commented Sep 12, 2023

hi @RobyRew @CorduroyZeus123 & all: ${\color{red}Can}$ we just run an apple VPS & automate the process for every extension?

@RobyRew
Copy link

RobyRew commented Sep 13, 2023

hi @RobyRew @CorduroyZeus123 & all: we just un an apple VPS & automate the process for every extension?

yes, for sure we can, but I personally don't know much about macOS apps build automation.

@avanderhoorn
Copy link

Any chance we can get the latest version uploaded to the app store?

@github-project-automation github-project-automation bot moved this from Todo to Done in Priority A Oct 18, 2023
@ImprovedTube ImprovedTube added the List of tasks Efficient to have a List for this (sub-)project. (Each task might be worth an extra thread.) label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) List of tasks Efficient to have a List for this (sub-)project. (Each task might be worth an extra thread.) 🧩Plan ready Solution or some specification noted; To-Do; steps for implementation (+raw brainstorming too maybe) 💭Question🌱 Q & A (We can move it to the 'Discussions'-Section, if no other label applies) z Safari occuring in Safari (only?)
Projects
Status: Done
Development

No branches or pull requests